refactor: rename dropdownContentRole to ariaRole #4248
Draft
refactor: rename dropdownContentRole to ariaRole #4248
dropdownContentRole to ariaRole #4248Conversation
Also moves maxWidth behavior if expandToViewport=true to the respective components, as this is a "feature" we want to keep for backward compatibility but it's not intended to be a part of the dropdown component.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4248 +/- ##
==========================================
+ Coverage 97.19% 97.24% +0.04%
==========================================
Files 886 886
Lines 26021 26040 +19
Branches 9433 9435 +2
==========================================
+ Hits 25291 25322 +31
+ Misses 724 712 -12
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
dropdownContentRoleprop of the Dropdown component to be namedariaRole, aligning its API with other components such as Flashbar.Related
[Quip proposal: RGJgABPXohP8RGJgABPXohP8]
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.